Ignore history events with worker_may_ignore: true. #2000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
LGTM, though may want @Quinn-With-Two-Ns to peek before merging.
| @@ -430,7 +428,11 @@ private void handleSingleEvent(HistoryEvent event, boolean hasNextEvent) { | |||
| replaying = false; | |||
| } | |||
|
|
|||
| Long initialCommandEventId = getInitialCommandEventId(event); | |||
| final long initialCommandEventId = getInitialCommandEventId(event); | |||
There was a problem hiding this comment.
Can we document getInitialCommandEventId and the fact that if it returns < 0 the event can be ignored?
There was a problem hiding this comment.
Added a docstring, but also switched from long / -1 to OptionalLong / empty() because it's less cognitive load.
Quinn-With-Two-Ns
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
worker_may_ignore: trueare skippedworker_may_ignoreis handled correctlyWhy?
The new
worker_may_ignoreflag is intended to mark events that can be handled as no-ops if the SDK doesn't know the event type.Checklist
Closes Fail task on unknown event when HistoryEvent.worker_may_ignore is false #1945
How was this tested: added new unit tests to verify the new behavior before implementing it.