Skip to content

[Feature Request] TracingInterceptor span kinds #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
northpowered opened this issue Jul 27, 2023 · 1 comment · Fixed by #356
Closed

[Feature Request] TracingInterceptor span kinds #357

northpowered opened this issue Jul 27, 2023 · 1 comment · Fixed by #356
Labels
enhancement New feature or request

Comments

@northpowered
Copy link
Contributor

This`s an issue for #356

Now, TracingInterceptor creates all spans with kind=INTERNAL

This PR changes this to CLIENT/SERVER model for convenient service graphs in APM (Tempo for ex.)

Before:
bad_sg

After:
good_sg
@northpowered northpowered added the enhancement New feature or request label Jul 27, 2023
@northpowered northpowered changed the title [Feature Request] FILL_TITLE_HERE [Feature Request] TracingInterceptor span kinds Jul 27, 2023
@northpowered northpowered mentioned this issue Jul 27, 2023
Merged
@cretz
Copy link
Member

cretz commented Jul 31, 2023

Thanks for the PR! Commented there. I completely agree we need to set this properly.

@cretz cretz closed this as completed in #356 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide Span.Kind for TracingInterceptor northpowered/sdk-python
2 participants
@cretz @northpowered