-
Notifications
You must be signed in to change notification settings - Fork 94
Provide Span.Kind for TracingInterceptor #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I did set kind properly in the .NET impl just not here for whatever reason.
I think you may need to run poe format
on the repo. Left some other suggestions too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Will merge if/when CI passes. Thanks!
What was changed
Added span kinds for TracingInterceptor
Now, all START actions are opentelemetry.trace.SpanKind.CLIENT
and all RUN actions are opentelemetry.trace.SpanKind.SERVER
For other actions kind=INTERNAL
Why?
Before this changes all spans was INTERNAL, so it was unavailable to build service graphs for APM (ex.: Grafana Tempo)
For example, this is the service graph with INTERNAL spans:

And this is for CLIENT/SERVER:

Spans attributes now look like this:


All experiments located here
This repo is a bit raw now, and hasn`t good README, but it`ll be fixed soon
Checklist
Closes [Feature Request] TracingInterceptor span kinds #357
How was this tested:
SDK developers reccomended testing, Integration tests were made here
Any docs updates needed?
No docs updated needed