Skip to content

Provide Span.Kind for TracingInterceptor #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Conversation

northpowered
Copy link
Contributor

@northpowered northpowered commented Jul 27, 2023

What was changed

Added span kinds for TracingInterceptor

Now, all START actions are opentelemetry.trace.SpanKind.CLIENT
and all RUN actions are opentelemetry.trace.SpanKind.SERVER

For other actions kind=INTERNAL

Why?

Before this changes all spans was INTERNAL, so it was unavailable to build service graphs for APM (ex.: Grafana Tempo)

For example, this is the service graph with INTERNAL spans:
bad_sg

And this is for CLIENT/SERVER:
good_sg

Spans attributes now look like this:
span_ex1
span_ex2

All experiments located here
This repo is a bit raw now, and hasn`t good README, but it`ll be fixed soon

Checklist

  1. Closes [Feature Request] TracingInterceptor span kinds #357

  2. How was this tested:
    SDK developers reccomended testing, Integration tests were made here

  3. Any docs updates needed?
    No docs updated needed

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@northpowered northpowered marked this pull request as ready for review July 27, 2023 07:14
@northpowered northpowered requested a review from a team as a code owner July 27, 2023 07:14
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I did set kind properly in the .NET impl just not here for whatever reason.

I think you may need to run poe format on the repo. Left some other suggestions too.

@northpowered
Copy link
Contributor Author

northpowered commented Aug 1, 2023

Thanks for this! I did set kind properly in the .NET impl just not here for whatever reason.

I think you may need to run poe format on the repo. Left some other suggestions too.

@cretz
Done here

  • Formatted
  • No default SpanKinds
  • No internal kinds

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Will merge if/when CI passes. Thanks!

@cretz cretz merged commit 393e5c8 into temporalio:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] TracingInterceptor span kinds
3 participants