Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Since pyright 1.1.344, my code stated to fail with errors such as the following:
The code being something like:
Despite looking legit, pyright did not like it. The issue is explained in microsoft/pyright#6875 and has to do with how the typing for methods is declared. I am attempting a fix here that I only tested with pyright for my use case, hoping that this will not break mypy.
Why?
To be able to use pyright with temporal.
Checklist
How was this tested:
Only a typing change, relying on CI to fully verify it.
Any docs updates needed?
No