Skip to content

Use minimal scope with pytest.raises #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

dandavison
Copy link
Contributor

@dandavison dandavison commented Jul 17, 2024

pytest.raises() scope should be limited to the statement that raises only.

This PR fixes a couple of bugs (mine) in test assertions and improves style in others that were not incorrect (other peoples').

@dandavison dandavison requested a review from a team as a code owner July 17, 2024 14:45
@dandavison dandavison merged commit e409d32 into temporalio:main Jul 17, 2024
12 checks passed
@dandavison dandavison deleted the fix-test branch July 17, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants