How to add module to disallowedModules?

[gajus]

We need to exclude a module from being bundled.

Contrary to the documentation, ignoreModules does not achieve that.

[bergundy]

Can you please provide more information why ignoreModules doesn't achieve what you want?
Here's what the bundler does internally FTR:

sdk-typescript/packages/worker/src/workflow/bundler.ts

Line 180 in 31c8cc2

protected async bundle(

.
Here's a test that successfully ignores dns

sdk-typescript/packages/test/src/test-bundler.ts

Line 60 in 31c8cc2

test('Workflow bundle can be created from code using ignoreModules', async (t) => {

.

[gajus]

I've added ['slonik', 'node:crypto'] and still getting error:

2023-01-26T16:23:52.171Z [ERROR] ERROR in node:crypto
2023-01-26T16:23:52.171Z [ERROR] Module build failed: UnhandledSchemeError: Reading from "node:crypto" is not handled by plugins (Unhandled scheme).
2023-01-26T16:23:52.171Z [ERROR] Webpack supports "data:" and "file:" URIs by default.
2023-01-26T16:23:52.171Z [ERROR] You may need an additional plugin to handle "node:" URIs.

so it seems at least one of them is still being included

[gajus]

Actually, now that I look at the Temporal source code, there is no logic there to actually exclude module. It only adds a warning if it is not already excluded.

[gajus]

It seems that it attempts to exclude it using alias, which unfortunately does not work for modules such as node:

webpack/webpack#14166

[bergundy]

LMK if removing the node: prefix solves your issue for now.

[gajus]

LMK if removing the node: prefix solves your issue for now.

It does not, as explained in that webpack issue.

[gajus]

I have no control over node: referenced in code, as it is coming from dependencies.

[mjameswh]

The issue you are facing is not directly about ignoreModules. It is that the workflow bundler is not compiling for the node target, and therefore, webpack does not even know how to process dependencies in the node: namespace.

Would it be possible for you to ignore the module that does import that node: dependency?

[gajus]

That's what I am trying to do with externals.

Anyway, overriding externals does the job.

// @see https://github.com/temporalio/sdk-typescript/issues/1036#issuecomment-1405322953
config.externals = {
  "node:crypto": "{}"
};

[gajus]

A Temporal-compatible patch:

const temporalExternals = config.externals;

config.externals = async (context, callback) => {
  if (context.request === 'node:crypto') {
    return 'var {}';
  }

  return temporalExternals(context, callback);
};

config.resolve.alias = {
  ...config.resolve.alias,
  '@': path.resolve(__dirname, '../..'),
  slonik: false,
};