Eager Workflow Start #1757
Open
Eager Workflow Start #1757
+160
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add startWithDetails to WorkflowClientInterceptor to support return type of WorkflowStartOutput, inject if not defined at _start call
THardy98
force-pushed
the
eager_workflow_start
branch
from
24a1314 to
9d137ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
The main change to accommodate eager workflow start was adding
startWithDetailstoWorkflowClientInterceptorto support a (new) return type ofWorkflowStartOutput. This allows us to return an object, giving us the ability to add new fields without issue - we addeagerlyStartedin this PR. This new interceptor method is injected if not defined at the internal_startcall, and adapts the existingstartinterceptor method to usestartWithDetails. We also define a new handle calledWorkflowHandleWithStartDetailswhich extends the existingWorkflowHandleWithFirstExecutionRunId, which now includes whether the workflow was started eagerly or not. Adding fields to the handle is an adopted pattern in the TS SDK.Why?
Support eager workflow start.
Closes [Feature Request] Eager Workflow Start #1348
How was this tested:
Existing integration tests and 2 new integration tests.
Any docs updates needed?
Probably