Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/activity/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ import {
Priority,
ActivityCancellationDetails,
IllegalStateError,
RetryPolicy,
} from '@temporalio/common';
import { msToNumber } from '@temporalio/common/lib/time';
import { SymbolBasedInstanceOfError } from '@temporalio/common/lib/type-helpers';
Expand Down Expand Up @@ -213,6 +214,14 @@ export interface Info {
* Priority of this activity
*/
readonly priority?: Priority;
/**
* The retry policy of this activity.
*
* Note that the server may have set a different policy than the one provided when scheduling the activity.
* If the value is undefined, it means the server didn't send information about retry policy (e.g. due to old server
* version), but it may still be defined server-side.
*/
readonly retryPolicy?: RetryPolicy;
}

/**
Expand Down
35 changes: 34 additions & 1 deletion packages/test/src/test-local-activities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
WorkflowHandle,
WorkflowStartOptions,
} from '@temporalio/client';
import { LocalActivityOptions } from '@temporalio/common';
import { LocalActivityOptions, RetryPolicy } from '@temporalio/common';
import { msToNumber } from '@temporalio/common/lib/time';
import { temporal } from '@temporalio/proto';
import { workflowInterceptorModules } from '@temporalio/testing';
Expand Down Expand Up @@ -624,3 +624,36 @@ export const interceptors: workflow.WorkflowInterceptorsFactory = () => {
],
};
};

export async function getRetryPolicyFromActivityInfo(
retryPolicy: RetryPolicy,
fromInsideLocal: boolean
): Promise<object | undefined> {
return await (fromInsideLocal
? workflow.proxyLocalActivities({ startToCloseTimeout: '1m', retry: retryPolicy }).retryPolicy()
: workflow.proxyActivities({ startToCloseTimeout: '1m', retry: retryPolicy }).retryPolicy());
}

test.serial('retryPolicy is set correctly', async (t) => {
const { executeWorkflow, createWorker } = helpers(t);
const worker = await createWorker({
activities: {
async retryPolicy(): Promise<object | undefined> {
return ActivityContext.current().info.retryPolicy;
},
},
});

const retryPolicy: RetryPolicy = {
backoffCoefficient: 1.5,
initialInterval: 2.0,
maximumAttempts: 3,
maximumInterval: 10.0,
nonRetryableErrorTypes: ['nonRetryableError'],
};

await worker.runUntil(async () => {
t.deepEqual(await executeWorkflow(getRetryPolicyFromActivityInfo, { args: [retryPolicy, true] }), retryPolicy);
t.deepEqual(await executeWorkflow(getRetryPolicyFromActivityInfo, { args: [retryPolicy, false] }), retryPolicy);
});
});
1 change: 1 addition & 0 deletions packages/testing/src/mocking-activity-environment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,4 +96,5 @@ export const defaultActivityInfo: activity.Info = {
scheduleToCloseTimeoutMs: 1000,
currentAttemptScheduledTimestampMs: 1,
priority: undefined,
retryPolicy: undefined,
};
1 change: 1 addition & 0 deletions packages/worker/src/worker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2132,6 +2132,7 @@ async function extractActivityInfo(
'currentAttemptScheduledTime'
),
priority: decodePriority(start.priority),
retryPolicy: decompileRetryPolicy(start.retryPolicy),
};
}

Expand Down
Loading