Skip to content

Request for example: CRF #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seanpmorgan opened this issue Jul 6, 2019 · 11 comments
Closed

Request for example: CRF #337

seanpmorgan opened this issue Jul 6, 2019 · 11 comments

Comments

@seanpmorgan
Copy link
Member

This is pending #22 and #314 but once it's merged we should be sure to add some examples as it's highly requested.

@seanpmorgan seanpmorgan added help wanted Needs help as a contribution tutorials good first issue blocked Pending something elses completion labels Jul 6, 2019
@howl-anderson
Copy link
Contributor

I can do this job when #314 is ready.

@Squadrick Squadrick removed the blocked Pending something elses completion label Aug 1, 2019
@HuggingLLM
Copy link

@seanpmorgan I find some example in 1.x. I try to use crf as a tf.keras.layers.Layer or tf.keras.Model. However, crf need y_true to get viterbi_sequence in
this example. Can you give some better example like use crf as a Layer or Model ?
https://github.com/tensorflow/tensorflow/blob/r1.15/tensorflow/contrib/crf/README.md

@howl-anderson
Copy link
Contributor

Hi @NLP-ZY , If you are looking for CRF keras layer for TF 2.x, this PR #377 is nearly done for this purpose, if you want the same keras layer in tf 1.15, there is a project (tf_crf_layer) for it.

@HuggingLLM
Copy link

@howl-anderson OK, thanks!

@seanpmorgan
Copy link
Member Author

Bumping this as a highly requested feature for our new layer

@Harsh188
Copy link
Contributor

Hey @seanpmorgan

I'd love to help out! I read through the long history of #22 #314 #377 #1733 and #1999. I'm familiarizing myself with layers/crf.py. If I'm not mistaken the objective is to build examples and develop user-friendly documentation for crf.py?

@bhack
Copy link
Contributor

bhack commented Sep 11, 2020

@Harsh188 yes

@Harsh188
Copy link
Contributor

Harsh188 commented Sep 11, 2020

Great! I'm gonna get started on that as soon as I can. I've noticed that It's not listed in the documentation how do I enable that? @bhack

@seanpmorgan
Copy link
Member Author

Great! I'm gonna get started on that as soon as I can. I've noticed that It's not listed in the documentation how do I enable that? @bhack

Hi @Harsh188 apologies for misunderstanding, what is not listed in the documentation?

@Harsh188
Copy link
Contributor

Harsh188 commented Sep 16, 2020

@seanpmorgan Whoops sorry for not being clear, I'm confused why layers/crf.py currently doesn't show up on the tfa api_docs. Could you also assign this task to me?

@seanpmorgan
Copy link
Member Author

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down

Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants