Skip to content

Used fixture instead of run_all_in_eager_and_graph_mode #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2020
Merged

Used fixture instead of run_all_in_eager_and_graph_mode #1331

merged 1 commit into from
Mar 23, 2020

Conversation

gabrieldemarmiesse
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse commented Mar 18, 2020 •
edited
Loading

Our longest test so far in the test suite test_interpolation went from 23s to 2s. I guess that tracing 20+ for loops is expensive :p

See #1328

not much has changed, except indentation and self.assertAllClose -> np.testing.assertAllClose.

@boring-cyborg boring-cyborg bot added the image label Mar 18, 2020
seanpmorgan
seanpmorgan approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is a great speed up and simplification

@seanpmorgan seanpmorgan merged commit ef8e08a into tensorflow:master Mar 23, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@gabrieldemarmiesse
Used fixture instead. (tensorflow#1331)
707864f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

@WindQAQ WindQAQ Awaiting requested review from WindQAQ

Assignees
No one assigned
Labels
cla: yes image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrieldemarmiesse @seanpmorgan @googlebot