Moved test_fit_simple_linear_model function out of run_all_in_graph_and_eager_mode. #1332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shreyashpatodia You are owner of some files modified in this pull request. |
|
Did you just move the code here? |
|
I took it out of the class to avoid making it run twice in graph mode. We're trying to get rid of the |
0xshreyash
approved these changes
Mar 19, 2020
|
Ah okay. Thanks! |
|
Thank you for the review! |
|
Thanks for the reviews @Squadrick, much appreciated! |
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't add the fixture to test in eager mode because running this test in eager mode takes 40seconds compared to 5 seconds with tf.function.
See #1328