Solarize_ops for Tensorflow Addons #1340
Conversation
|
It would be nice to have tests for each op. Maybe add an image like #1338 |
Sure |
|
@abhichou4 : Shall i need to test the images with all dtypes |
|
I am getting some errors @abhichou4 could you please help me out with this. |
Have a look at contribution guidelines and add the pre-commit hooks. Also, BUILD and init.py need to be changed. |
@abhichou4 : Could you please review my commit. |
| "interpolate_spline.py", | ||
| "connected_components.py", | ||
| "resampler_ops.py", | ||
| "solarize_ops.py", |
There was a problem hiding this comment.
compose_ops.py is missing here.
Running |
Actually i am using windows so that command was not working it shows error. So you have any other options like pylint |
You are on Windows you need to run that in Docker. I've prepared a devcontainer for Vscode ide+Vscode remote extension users but It Is still not merged. It could simplify the Dev environment also on Windows. You could give a try Is here: |
Thank you very much @bhack because for now i am using three commands separately black , pylint , flake8. So i need a way to do this fast. Thank you. |
| @@ -1,25 +1,28 @@ | |||
| licenses(["notice"]) # Apache 2.0 | |||
There was a problem hiding this comment.
This is not how the BUILD is formatted. Please look at Development tips to know how to auto-format your code.
If you're on Windows, you can use docker to do the same.
| @@ -0,0 +1,30 @@ | |||
| """ This module is used to invert all pixel values above a threshold | |||
There was a problem hiding this comment.
Missing LICENSE, see any other source file to get the license.
| """Method to solarize the image | ||
| image: input image | ||
| threshold: threshold value to solarize the image | ||
| """ |
There was a problem hiding this comment.
Look at other source files to see how docstrings are written.
| import tensorflow as tf | ||
|
|
||
|
|
||
| def solarize(image, threshold=128): |
| """Method to add solarize to the image | ||
| image: input image | ||
| addition: addition amount to add in image | ||
| threshold: threshold value to solarize the image | ||
| """ |
There was a problem hiding this comment.
Look at other source files to see how docstrings are written.
| # we add 'addition' amount to it and then clip the | ||
| # pixel value to be between 0 and 255. The value | ||
| # of 'addition' is between -128 and 128. | ||
| added_image = tf.cast(image, tf.int64) + addition |
There was a problem hiding this comment.
Why the cast to int64 instead of int32?
| # For each pixel in the image less than threshold | ||
| # we add 'addition' amount to it and then clip the | ||
| # pixel value to be between 0 and 255. The value | ||
| # of 'addition' is between -128 and 128. |
There was a problem hiding this comment.
Add a check to ensure addition is between -128 and 128.
| @@ -0,0 +1,30 @@ | |||
| """Test of solarize_ops""" | |||
| from absl.testing import parameterized | ||
|
|
||
|
|
||
| @test_utils.run_all_in_graph_and_eager_modes |
| class SolarizeOPSTest(tf.test.TestCase, parameterized.TestCase): | ||
| """SolarizeOPSTest class to test the solarize images""" | ||
|
|
||
| def test_solarize(self): |
@vinayvr11 There is a section for running pre-commit with Windows. Could you expand on the error you're getting and we'll be sure to update the steps accordingly: |
|
This is now in https://github.com/tanzhenyu/image_augmentation /cc @tanzhenyu |
See #1333
solarize_opsfor image processing to add in Tensorflow Addons. Contains:solarizesolarize_add