Test parse time in eager mode #1348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are owner of some files modified in this pull request. |
helinwang
reviewed
Mar 19, 2020
| @@ -26,7 +26,7 @@ | |||
| tf.no_gradient("Addons>ParseTime") | |||
|
|
|||
|
|
|||
| def parse_time(time_string: str, time_format: str, output_unit: str) -> str: | |||
| def parse_time(time_string: str, time_format: str, output_unit: str) -> tf.Tensor: | |||
There was a problem hiding this comment.
The return type is changed. Does it still work for non-eager mode / v1 compat mode?
There was a problem hiding this comment.
Sorry,I should have said it. I changed the return type because it was wrong in the first place. The function returns a tensor, not a python string.
There was a problem hiding this comment.
Ah you are right, thanks!
seanpmorgan
approved these changes
Mar 19, 2020
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* Run parse_time_op_test.py in eager mode * Fix test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1328