Skip to content

Adding another maintainer into CODEOWNERS file #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 25, 2020

Conversation

pkan2
Copy link
Contributor

@pkan2 pkan2 commented Mar 24, 2020

Hello!

Can I add another maintainer lokhande-vishnu for the /tensorflow_addons/optimizers/conditional_gradient*.py into the addons/.github/CODEOWNERS file?

Thank you!

@boring-cyborg boring-cyborg bot added the github label Mar 24, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@gabrieldemarmiesse
Copy link
Member

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for supporting the ConditionalGradients optimizer!

@gabrieldemarmiesse gabrieldemarmiesse merged commit f0cef01 into tensorflow:master Mar 25, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
* Improve with providing Nuclear Norm Constraint

* Update based on feedback

* Update Based on Feedback

* Solve Conflict

* Solve Conflict

* change format and fix conflict

* Update CODEOWNERS with adding another maintainer

Update CODEOWNERS with adding lokande-vishnu as another maintainer of /tensorflow_addons/optimizers/conditional_gradient.py.

Co-authored-by: gabrieldemarmiesse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants