Skip to content

Moved test out of run_in_graph_and_eager_mode in sparsemax. #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Moved test out of run_in_graph_and_eager_mode in sparsemax. #1409

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d90b8b
Moved test out of run_in_graph_and_eager_mode in sparsemax.
gabrieldemarmiesse Mar 25, 2020
1c75611
Merge branch 'master' into pytestify25
gabrieldemarmiesse Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions tensorflow_addons/activations/sparsemax_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,26 +210,6 @@ def test_constant_add(self, dtype=None):
tf_sparsemax_zpc, tf_sparsemax_z, half_atol=5e-3
)

def test_permutation(self, dtype=None):
"""check sparsemax proposition 3."""
random = np.random.RandomState(6)

z = random.uniform(low=-3, high=3, size=(test_obs, 10))
_, p = self._tf_sparsemax(z, dtype)

for i in range(test_obs):
per = random.permutation(10)

tf_sparsemax_op, tf_sparsemax_out = self._tf_sparsemax(
z[i, per].reshape(1, -1), dtype
)
p_expected = p[i, per].reshape(1, -1)

self.assertAllCloseAccordingToType(
p_expected, tf_sparsemax_out, half_atol=5e-3
)
self.assertShapeEqual(p_expected, tf_sparsemax_op)


@pytest.mark.parametrize("dtype", ["float32", "float64"])
def test_two_dimentional(dtype):
Expand Down Expand Up @@ -268,6 +248,26 @@ def test_diffrence(dtype):
assert 0 <= p[val, j] - p[val, i] <= z[val, j] - z[val, i] + etol


@pytest.mark.parametrize("dtype", ["float32", "float64"])
def test_permutation(dtype):
"""check sparsemax proposition 3."""
random = np.random.RandomState(6)

z = random.uniform(low=-3, high=3, size=(test_obs, 10))
p = sparsemax(z.astype(dtype)).numpy()

for i in range(test_obs):
per = random.permutation(10)

tf_sparsemax_out = sparsemax(z[i, per].reshape(1, -1).astype(dtype))
p_expected = p[i, per].reshape(1, -1)

test_utils.assert_allclose_according_to_type(
p_expected, tf_sparsemax_out, half_atol=5e-3
)
assert p_expected.shape == tf_sparsemax_out.shape


@pytest.mark.parametrize("dtype", ["float32", "float64"])
def test_gradient_against_estimate(dtype):
"""check sparsemax Rop, against estimated Rop."""
Expand Down