-
Notifications
You must be signed in to change notification settings - Fork 614
Moved some functions out of run_all_in_graph_and_eager_mode in attention_wrapper_test.py. #1639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved some functions out of run_all_in_graph_and_eager_mode in attention_wrapper_test.py. #1639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gabrieldemarmiesse. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indent seems to be quite weird in this file, are we using 4 space or 2 space?
Also, I haven't follow the change history closely, but currently there is a nest structure of test classes in this file, which is bit anti-pattern. Is that expected?
I'm not sure I follow you, it's 4 spaces, it's enforced with Also for the background, sorry, I should have been more explicit, see #1328 We want to get rid of the decorator that traces test functions (run_all_in_graph_and_eager_mode). |
I think in TensorFlow using 2 space, but here is with |
No description provided.