Finishing the pytest migration. #1661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldemarmiesse
requested review from
guillaumekln and
qlzh727
as code owners
qlzh727
reviewed
Apr 14, 2020
gabrieldemarmiesse
changed the title
gabrieldemarmiesse
changed the title
gabrieldemarmiesse
changed the title
seanpmorgan
requested changes
Apr 23, 2020
seanpmorgan
approved these changes
Apr 24, 2020
|
|
||
| with self.cached_session(use_gpu=True): |
There was a problem hiding this comment.
Could we mark this as a TODO to enable GPU testing in #1713 for this
There was a problem hiding this comment.
We could, but I believe we don't need to test on gpu here. We don't depend on any custom op and we don't test in float16. I believe that this is tensorflow's job to do the right thing on gpu here, not ours. But I don't have a very strong opinion there, in the new setup, it's just going to be an additional decorator to add gpu testing.
|
|
||
| def _testWithMaybeMultiAttention( | ||
| self, | ||
| is_multi, |
There was a problem hiding this comment.
So we remove all logic for handling is_multi. It was never used in the test suite, but I'm less familiar with this module and don't know if it'll ever be needed in testing going forward. Okay to remove IMO since it wasn't used and will be in git history.
ashutosh1919
pushed a commit
to ashutosh1919/addons
that referenced
this pull request
Jul 12, 2020
* Removed run_all_in_graph_and_eager_mode in attention_wrapper_test.py. * Refactoring. * Some black bug. * Done one test. * Fuse functions. * Rewrite with unittest2pytest. * Moved function. * Removed use gpu. * Remove prints. * Removed one assertAllclose. * Removed some more self. * Removed some more self. * Moved function out of class. * Removed one function. * Removed some self. * Moved a function out of tf.test.TestCase. * Removed decorator. * IIII * Removed the run functions eagerly. * Removed import. * Removed is_multi. * Removed self for batch. * Removed some more self. * Removed some more self. * Removed some stuff. * Unholy stuff there. * Found a way to replace that. * Works well. * Removed self completely from function. * Removed self from parameters. * Managed to move the function. * It works with pytest only. * Fully converted to pytest. * Minor simplification. * Some comment. * Removed some unused functions. * Removed some elements from the test_no_deprecated_v1. * Removed some files from blacklists. * Forgot to remove run_eagerly. * Removed tf.executing_eagerly.
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* Removed run_all_in_graph_and_eager_mode in attention_wrapper_test.py. * Refactoring. * Some black bug. * Done one test. * Fuse functions. * Rewrite with unittest2pytest. * Moved function. * Removed use gpu. * Remove prints. * Removed one assertAllclose. * Removed some more self. * Removed some more self. * Moved function out of class. * Removed one function. * Removed some self. * Moved a function out of tf.test.TestCase. * Removed decorator. * IIII * Removed the run functions eagerly. * Removed import. * Removed is_multi. * Removed self for batch. * Removed some more self. * Removed some more self. * Removed some stuff. * Unholy stuff there. * Found a way to replace that. * Works well. * Removed self completely from function. * Removed self from parameters. * Managed to move the function. * It works with pytest only. * Fully converted to pytest. * Minor simplification. * Some comment. * Removed some unused functions. * Removed some elements from the test_no_deprecated_v1. * Removed some files from blacklists. * Forgot to remove run_eagerly. * Removed tf.executing_eagerly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing the pytest migration.