Skip to content

Install setuptools first #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented Jul 15, 2020

Build broke yesterday because setuptools does not present in dist-packages of python3.5 on linux. Try to investigate and fix it :-(

https://github.com/tensorflow/addons/pull/1994/checks?check_run_id=867618216

@WindQAQ WindQAQ requested a review from a team July 15, 2020 02:19
@WindQAQ
Copy link
Member Author

WindQAQ commented Jul 15, 2020

cc @tensorflow/sig-addons-maintainers

Copy link
Member

@facaiy facaiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

@facaiy
Copy link
Member

facaiy commented Jul 15, 2020

@gabrieldemarmiesse @seanpmorgan Hi, the PR makes sense for me, could you double check it? Thanks

image

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx... not sure what triggered this but the fix is sufficient

@seanpmorgan seanpmorgan merged commit e8f8ca7 into tensorflow:master Jul 15, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants