Skip to content

Change CRF layer dtype #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2020

Conversation

WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented Dec 7, 2020

Description

Addresses #2231. Note that mixed precision has already been fixed in f429133, but the behavior is different from TensorFlow semantics.

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

Passes original tests.

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@boring-cyborg boring-cyborg bot added the text label Dec 7, 2020
@google-cla google-cla bot added the cla: yes label Dec 7, 2020
@WindQAQ
Copy link
Member Author

WindQAQ commented Dec 7, 2020

Hi @xuxingya, can you review this if time allows? Thank you!

@WindQAQ WindQAQ requested review from seanpmorgan and bhack December 7, 2020 01:46
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT thx!

@seanpmorgan seanpmorgan merged commit b661c98 into tensorflow:master Dec 8, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
* Change layer dtype
* Cast to self._compute_dtype
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants