Skip to content

Use multipython image for dev container #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

seanpmorgan
Copy link
Member

Description

Previous container only supports up to py3.6 which TF2.7 is not built for. TF team has stopped publishing these custom-op images since TF2.5.

Using the CUDA image makes the container larger, but it still uses the cpu only version of TF so it's accurate to call it dev_cpu. Building the gpu image would be pretty trivial now, but also this limits the maintenance burden on our team.

There is no multipython container without GPU installs:
https://console.cloud.google.com/gcr/images/tensorflow-testing/GLOBAL

@google-cla google-cla bot added the cla: yes label Nov 9, 2021
@seanpmorgan seanpmorgan requested a review from bhack November 9, 2021 04:41
@bhack
Copy link
Contributor

bhack commented Nov 9, 2021

Is this image used only to produce wheels?

@seanpmorgan
Copy link
Member Author

seanpmorgan commented Nov 9, 2021

Is this image used only to produce wheels?

It is the image we use to create wheels. It has the proper gcc, bazel, and python installations. Currently our build it broken due to the dev container not being able to be built with TF2.7 + Python3.6:
https://github.com/tensorflow/addons/actions/runs/1437774966

This is gaiting a 0.15 release

@seanpmorgan seanpmorgan merged commit f77fe34 into tensorflow:master Nov 9, 2021
@seanpmorgan seanpmorgan deleted the new-dev-base branch November 9, 2021 14:39
@bhack
Copy link
Contributor

bhack commented Nov 16, 2021

The image is very large now:

https://hub.docker.com/r/tfaddons/dev_container/tags

This is really going to slow down the bootstrap of the devcontainer to pull the image in Vsocde and also sto start a Github Codespaces

@bhack
Copy link
Contributor

bhack commented Nov 16, 2021

As this is linked in https://github.com/tensorflow/addons/blob/master/.devcontainer/Dockerfile#L2

Do we have any alternative for the developer env?

@seanpmorgan
Copy link
Member Author

Not that I know of, the old container stopped being updated by TF dev infra. We can either request they resume that -- but alternatively they mentioned managed dev containers at the TF community day. We should get an ETA.

@bhack
Copy link
Contributor

bhack commented Nov 16, 2021

That it is part of #2515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants