Skip to content

experimental API policy #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 6, 2020
Merged

Conversation

alextp
Copy link
Contributor

@alextp alextp commented Mar 16, 2020

No description provided.

Copy link

@karmel karmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a user, some questions I would have:

  1. How will this be enforced?
  2. I was using the experimental ABC API, and it was non-compliant because of XYZ. Why did that happen?What recourse do I have?

@alextp
Copy link
Contributor Author

alextp commented Mar 20, 2020

  1. How will this be enforced?

By the same API review process we use to enforce our other API policies? Or did you mean something else (like: "will we write tools to introspect into these APIs?", to which the answer is yes, soon)

  1. I was using the experimental ABC API, and it was non-compliant because of XYZ. Why did that happen?What recourse do I have?

I think this policy says that we cannot remove experimental APIs that break people without a lot of warning (or at all, if we cannot find a good replacement), so it's on us to fix noncompliant APIs as much as we can.

@alextp
Copy link
Contributor Author

alextp commented Apr 6, 2020 via email

@@ -202,7 +202,10 @@ prefer experimental namespaces when possible, so prefer

Experimental APIs are APIs intended to be added to TensorFlow as-is, but which
we reserve the right to change in backwards-incompatible ways if we have
to.
to. This is different from apis in `tensorflow/addons`, many of which are not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes it more clear - thanks!

@martinwicke martinwicke merged commit 62e34f5 into tensorflow:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants