This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Extend 'Array' and 'Array.DifferentiableView' for aggregate math and collection protocols. #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
changed the title
|
@rxwei do you know why it causes IRGen to crash? |
dan-zheng
approved these changes
Jul 10, 2019
|
@eaplatanios I haven't investigated this yet. Has something to do with |
Conform `Array` and `Array.DifferentiableView` to aggregate math protocols and collection protocols so that array derivatives can be handled by optimizers. * Conform `Array` to `EleemntaryFunctions` where `Element` conforms. * Conform `Array.DifferentiableView` to `EleemntaryFunctions` where `Element` conforms. * Conform `Array.DifferentiableView` to `VectorProtocol` where `Element` conforms. * Conform `Array.DifferentiableView` to `PointwiseMultiplicative` where `Element` conforms. * Conform `Array.DifferentiableView` to `MutableCollection`, `RandomAccessCollection`, and `RangeReplaceableCollection`. Some (if not all) of these belong to the standard library, but adding these to stdlib will cause IRGen to crash at the moment. This unblocks building fast.ai notebooks against new optimizer implementations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conform
ArrayandArray.DifferentiableViewto aggregate math protocols and collection protocols so that array derivatives can be handled by optimizers.ArraytoEleemntaryFunctionswhereElementconforms.Array.DifferentiableViewtoEleemntaryFunctionswhereElementconforms.Array.DifferentiableViewtoVectorProtocolwhereElementconforms.Array.DifferentiableViewtoPointwiseMultiplicativewhereElementconforms.Array.DifferentiableViewtoMutableCollection,RandomAccessCollection, andRangeReplaceableCollection.Some (if not all) of these belong to the standard library, but adding these to stdlib will cause IRGen to crash at the moment.
This unblocks building fast.ai notebooks against new optimizer implementations.