uploader: set user agent for frontend handshake #2934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Plan: Running against a local frontend server, `tensorboard/2.1.0a0` shows up in the server logs where previously there was `python-requests/2.22.0`. wchargin-branch: uploader-user-agent
wchargin-branch: uploader-user-agent wchargin-source: 630d7b980f2b7796e79ad9bd42b12f16e57f8a3b
wchargin
added a commit
to wchargin/tensorboard
that referenced
this pull request
Nov 25, 2019
Test Plan: Running against a local frontend server, `tensorboard/2.1.0a0` shows up in the server logs where previously there was `python-requests/2.22.0`. Unit tests also included. wchargin-branch: uploader-user-agent
Merged
wchargin
added a commit
that referenced
this pull request
Nov 25, 2019
Test Plan: Running against a local frontend server, `tensorboard/2.1.0a0` shows up in the server logs where previously there was `python-requests/2.22.0`. Unit tests also included. wchargin-branch: uploader-user-agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan:
Running against a local frontend server,
tensorboard/2.1.0a0shows upin the server logs where previously there was
python-requests/2.22.0.Unit tests also included.
wchargin-branch: uploader-user-agent