build: set srcs_version = "PY3" everywhere
#4361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
We dropped official support for Python 2.7 early this year, but our
Python build rules still had `srcs_version = "PY2AND3"` in many places
due to lingering Google dependents. Now is the time to fix that, so that
we may move forward with even more conviction.
Generated with:
```
buildozer '//...:%py_library' 'set srcs_version PY3' &&
bazel query 'filter(expect.*installed, //tensorboard:all)' \
| xargs buildozer 'remove srcs_version' &&
git ls-files -z | xargs -0 sed -i s/PY2AND3/PY3/
```
…which skips adding it to binaries and tests that don’t yet have it.
(They don’t pose a problem with reverse dependencies.) The global `sed`
hits `third_party/*.BUILD` and the `*.bzl` files.
Test Plan:
Sync into Google, run a global presubmit, and see what happens. Last
time I did this, only three targets failed (out of all our transitive
reverse dependencies), and they all looked like false positives.
wchargin-branch: build-srcs-version-py3
wchargin-source: ac12d89ae6ba74b57e243e3cfaafd789931b5f3d
|
Googlers, see: http://cl/343401587 |
|
We’re happy with the global presubmit results. Plan to merge this on |
bileschi
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We dropped official support for Python 2.7 early this year, but our
Python build rules still had
srcs_version = "PY2AND3"in many placesdue to lingering Google dependents. Now is the time to fix that, so that
we may move forward with even more conviction.
Generated with:
…which skips adding it to binaries and tests that don’t yet have it.
(They don’t pose a problem with reverse dependencies.) The global
sedhits
third_party/*.BUILDand the*.bzlfiles.Test Plan:
After syncing into Google, a global presubmit only includes failures
that seem to be false positives.
wchargin-branch: build-srcs-version-py3