Skip to content

Upgrade Black to v20.8b1 and drop py27 and py35 #4409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 1, 2020
Merged

Upgrade Black to v20.8b1 and drop py27 and py35 #4409

merged 4 commits into from
Dec 1, 2020

Conversation

wchargin
Copy link
Contributor

@wchargin wchargin commented Dec 1, 2020

Fixes #4406. See that issue for discussion.

To be merged with rebase.

@wchargin
ci: upgrade Black to v20.8b1, drop Python 2.7/3.5, and disable check
6d85d7a 
Summary:
See #4406. Subsequent commits will re-run Black with the new settings
and new version (these commits will be ignored for blame purposes), and
then another commit will re-enable enforcement.

wchargin-branch: black-20x-no27-no35
@wchargin wchargin added type:build/install dependencies Pull requests that update a dependency file labels Dec 1, 2020
@google-cla google-cla bot added the cla: yes label Dec 1, 2020
tensorboard-gardener and others added 3 commits November 30, 2020 19:04
@tensorboard-gardener @wchargin
black: reformat after dropping Python 2.7 and 3.5
f14d483 
Summary:
This is a clean run of Black 19.10b0 after removing `py27` and `py35`
from the list of target versions in `pyproject.toml`. See #4406.

wchargin-branch: black-20x-no27-no35
@tensorboard-gardener @wchargin
black: reformat after upgrading to Black v20.8b1
f896d86 
Summary:
This is a clean run of Black v20.8b1. See #4406.

wchargin-branch: black-20x-no27-no35
@wchargin
ci: re-enable Black enforcement
48a9be7 
Summary:
Previous commits have reformatted at Black v20.8b1 without support for
Python 2.7 or 3.5, so we can turn this check back on. See #4406.

Test Plan:
That CI passes suffices.

wchargin-branch: black-20x-no27-no35
@wchargin wchargin force-pushed the wchargin-black-20x-no27-no35 branch from 6851b4f to 48a9be7 Compare December 1, 2020 03:05
@google-cla
Copy link

google-cla bot commented Dec 1, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Dec 1, 2020
@wchargin
Copy link
Contributor Author

wchargin commented Dec 1, 2020

(Force-push to attribute reformats to TensorBoard Gardener.)

@wchargin wchargin added cla: yes and removed cla: no labels Dec 1, 2020
@wchargin
Copy link
Contributor Author

wchargin commented Dec 1, 2020

CLAs are okay because I wrote or generated all these commits.

@wchargin wchargin requested a review from psybuzz December 1, 2020 03:56
psybuzz
psybuzz approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@psybuzz psybuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@wchargin
Copy link
Contributor Author

wchargin commented Dec 1, 2020

Thanks!

@wchargin wchargin merged commit 3eb0b40 into master Dec 1, 2020
@wchargin wchargin deleted the wchargin-black-20x-no27-no35 branch December 1, 2020 05:07
@wchargin wchargin changed the title Upgrade Black to v20.8b1 and drop py27 and p35 Upgrade Black to v20.8b1 and drop py27 and py35 Dec 1, 2020
wchargin added a commit that referenced this pull request Dec 1, 2020
@wchargin
blame: ignore Black v20.8b1 and py27/py35 reformattings
fbceefc 
Summary:
From #4409; see also #4406 for discussion.

Test Plan:
The output of `git blame tensorboard/backend/application.py` no longer
has any lines blaming to either of the commits in question.

wchargin-branch: black-20.8b1-unblame
wchargin-source: cb748b7e7f41469c5e0baf6ba92b8f025132fe7a
@wchargin wchargin mentioned this pull request Dec 1, 2020
Merged
wchargin added a commit that referenced this pull request Dec 1, 2020
@wchargin
blame: ignore Black v20.8b1 and py27/py35 reformattings (#4410)
73e71f0 
Summary:
From #4409; see also #4406 for discussion.

Test Plan:
The output of `git blame tensorboard/backend/application.py` no longer
has any lines blaming to either of the commits in question.

wchargin-branch: black-20.8b1-unblame
wchargin added a commit that referenced this pull request Dec 1, 2020
@wchargin
black: reformat tensorboard/manager.py
2d2c3f6 
Summary:
CI skew between #4409 and #4407 that I didn’t realize.

Test Plan:
GitHub CI suffices.

wchargin-branch: black-reformat-manager
wchargin-source: 78c9403c871588dc6c4d4f93783e1f332a577164
@wchargin wchargin mentioned this pull request Dec 1, 2020
Merged
wchargin added a commit that referenced this pull request Dec 2, 2020
@wchargin
black: reformat tensorboard/manager.py (#4414)
81fc828 
Summary:
CI skew between #4409 and #4407 that I didn’t realize.

Test Plan:
GitHub CI suffices.

wchargin-branch: black-reformat-manager
@wchargin wchargin mentioned this pull request Dec 16, 2020
Open
10 tasks
@stephanwlee stephanwlee mentioned this pull request Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psybuzz psybuzz psybuzz approved these changes

Assignees
No one assigned
Labels
cla: yes dependencies Pull requests that update a dependency file type:build/install
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Black updates: drop py27+py35; upgrade from 19.x to 20.x
3 participants
@wchargin @psybuzz @tensorboard-gardener