Skip to content

[r2.1 cherry-pick] Fix pip package API generation #34822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lgeiger
Copy link
Contributor

@lgeiger lgeiger commented Dec 4, 2019

This cherry picks #34629 onto the r2.1 release branch.

This doesn't completely solve tensorflow/community#182 but should get autocomplete working.

/cc @annarev @mihaimaruseac

@lgeiger lgeiger requested a review from annarev as a code owner December 4, 2019 11:11
@tensorflow-bot tensorflow-bot bot added the size:M CL Change Size: Medium label Dec 4, 2019
@goldiegadde goldiegadde added the kokoro:force-run Tests on submitted change label Dec 4, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 4, 2019
@goldiegadde goldiegadde merged commit 8da6f37 into tensorflow:r2.1 Dec 5, 2019
@lgeiger lgeiger deleted the r2.1-cherry-pick-pip-package-gen branch December 5, 2019 07:56
@mihaimaruseac
Copy link
Collaborator

Unfortunately having this in in a pip package causes segfaults on python -c "import scipy; import tensorflow". We will rollback for now, to investigate and then rollforward with a fix or provide more instructions.

@lgeiger
Copy link
Contributor Author

lgeiger commented Dec 18, 2019

Unfortunately having this in in a pip package causes segfaults on python -c "import scipy; import tensorflow"

That is very strange, I don't see why this change could cause a segfault.
I cannot reproduce the segfault with macOS, Python 3.7.5, Tensorflow 2.1.0rc1, SciPy 1.4.0 and NumPy 1.17.4.

@mihaimaruseac
Copy link
Collaborator

That is indeed strange, we were able to reproduce it on Ubuntu, Python3.5, TF 2.1.0rc1, scipy 1.4.0.

We'll build a pip package with this rolledback and try it to see if the culprit finder was right. If not, we'll roll it forward again

@lgeiger
Copy link
Contributor Author

lgeiger commented Dec 18, 2019

I can reproduce the failure on Colab with scipy==1.4.0, but everything works fine on Colab with scipy==1.3.3.

It might be related to scipy/scipy#11237, which now surfaces due to possible changes in import ordering.

@mihaimaruseac
Copy link
Collaborator

Rolling back the roll back in #35270. Indeed, the culprit was the scipy bug, not this PR. Apologies for the mistaken rollback

@lgeiger
Copy link
Contributor Author

lgeiger commented Dec 20, 2019

Thanks for investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes size:M CL Change Size: Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants