-
Notifications
You must be signed in to change notification settings - Fork 74.7k
[r2.1 cherry-pick] Fix pip package API generation #34822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r2.1 cherry-pick] Fix pip package API generation #34822
Conversation
Unfortunately having this in in a pip package causes segfaults on |
That is very strange, I don't see why this change could cause a segfault. |
That is indeed strange, we were able to reproduce it on Ubuntu, Python3.5, TF 2.1.0rc1, scipy 1.4.0. We'll build a pip package with this rolledback and try it to see if the culprit finder was right. If not, we'll roll it forward again |
I can reproduce the failure on Colab with It might be related to scipy/scipy#11237, which now surfaces due to possible changes in import ordering. |
Rolling back the roll back in #35270. Indeed, the culprit was the scipy bug, not this PR. Apologies for the mistaken rollback |
Thanks for investigating. |
This cherry picks #34629 onto the
r2.1
release branch.This doesn't completely solve tensorflow/community#182 but should get autocomplete working.
/cc @annarev @mihaimaruseac