Skip to content

Switch from PyEval_CallObject to PyObject_Call #72232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

shadchin
Copy link
Contributor

python/cpython#105107 Remove deprecate PyEval_CallObject() function.

There are replacement functions like PyObject_Call() and PyObject_CallFunction() which exist since Python 3.0 at least and so is backward compatible.

python/cpython#105107 Remove deprecate PyEval_CallObject() function.

> There are replacement functions like PyObject_Call() and PyObject_CallFunction() which exist since Python 3.0 at least and so is backward compatible.
@shadchin shadchin requested a review from rohan100jain as a code owner July 20, 2024 20:02
@google-ml-butler google-ml-butler bot added awaiting review Pull request awaiting review size:S CL Change Size: Small labels Jul 20, 2024
@keerthanakadiri
Copy link
Contributor

Hi @rohan100jain , Can you please review this PR? Thank you

6 similar comments
@keerthanakadiri
Copy link
Contributor

Hi @rohan100jain , Can you please review this PR? Thank you

@keerthanakadiri
Copy link
Contributor

Hi @rohan100jain , Can you please review this PR? Thank you

@keerthanakadiri
Copy link
Contributor

Hi @rohan100jain , Can you please review this PR? Thank you

@keerthanakadiri
Copy link
Contributor

Hi @rohan100jain , Can you please review this PR? Thank you

@keerthanakadiri
Copy link
Contributor

Hi @rohan100jain , Can you please review this PR? Thank you

@keerthanakadiri
Copy link
Contributor

Hi @rohan100jain , Can you please review this PR? Thank you

@shadchin
Copy link
Contributor Author

@keerthanakadiri
Can anyone else take a look at this PR?

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 1, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 1, 2024
@keerthanakadiri keerthanakadiri added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Oct 9, 2024
@copybara-service copybara-service bot merged commit 3353bb3 into tensorflow:master Oct 15, 2024
7 of 8 checks passed
copybara-service bot pushed a commit that referenced this pull request Oct 15, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=#72232 from shadchin:python313 846468d
PiperOrigin-RevId: 685952916
@shadchin shadchin deleted the python313 branch October 15, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Pull request awaiting review ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants