Skip to content

Add example for saving / loading models using IndexedDB to Iris demo #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 25, 2018

Conversation

caisq
Copy link
Collaborator

@caisq caisq commented May 22, 2018

  • Remove the capability to load a converted Keras model from the local
    file system, a) to avoid confusion, b) this functionality is not
    highly useful anymore.
  • Fix an issue in the widths of the vega-embed plots: they somehow
    started resizing. This PR makes then fixed, as they should be.

Towards: tensorflow/tfjs#13


This change is Reviewable

* Remove the capability to load a converted Keras model from the local
  file system, a) to avoid confusion, b) this functionality is not
  highly useful anymore.
* Fix an issue in the widths of the vega-embed plots: they somehow
  started resizing. This PR makes then fixed, as they should be.
@caisq caisq requested review from nsthorat and davidsoergel May 22, 2018 15:51
@caisq
Copy link
Collaborator Author

caisq commented May 22, 2018

See screenshot at:

image

@davidsoergel
Copy link
Member

:lgtm_strong:


Reviewed 5 of 7 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


iris/loader.js, line 51 at r2 (raw file):

client-side where

nit: client-side location where


iris/serve.sh, line 31 at r2 (raw file):

# Ensure that http-server is available
# yarn

Should this be commented out?


Comments from Reviewable

iris/serve.sh Outdated
@@ -28,14 +28,14 @@ NODE_ENV=development
RESOURCE_PORT=1235

# Ensure that http-server is available
yarn
# yarn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment meant to be maintained? Does it make sense to keep it?

@bileschi
Copy link
Contributor

:lgtm_strong:


Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.


Comments from Reviewable

@caisq
Copy link
Collaborator Author

caisq commented May 25, 2018

Thanks for your reviews!


Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.


iris/loader.js, line 51 at r2 (raw file):

Previously, davidsoergel (David Soergel) wrote…
client-side where

nit: client-side location where

Done.


iris/serve.sh, line 31 at r2 (raw file):

Previously, davidsoergel (David Soergel) wrote…

Should this be commented out?

Restored.


iris/serve.sh, line 31 at r2 (raw file):

Previously, bileschi (Stanley Bileschi) wrote…

Is this comment meant to be maintained? Does it make sense to keep it?

Restored yarn.


Comments from Reviewable

@caisq caisq merged commit e52172a into tensorflow:master May 25, 2018
@caisq caisq deleted the iris-save-load branch May 25, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants