-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add example for saving / loading models using IndexedDB to Iris demo #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Remove the capability to load a converted Keras model from the local file system, a) to avoid confusion, b) this functionality is not highly useful anymore. * Fix an issue in the widths of the vega-embed plots: they somehow started resizing. This PR makes then fixed, as they should be.
Reviewed 5 of 7 files at r1, 2 of 2 files at r2. iris/loader.js, line 51 at r2 (raw file):
nit: client-side location where iris/serve.sh, line 31 at r2 (raw file):
Should this be commented out? Comments from Reviewable |
iris/serve.sh
Outdated
@@ -28,14 +28,14 @@ NODE_ENV=development | |||
RESOURCE_PORT=1235 | |||
|
|||
# Ensure that http-server is available | |||
yarn | |||
# yarn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment meant to be maintained? Does it make sense to keep it?
Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful. Comments from Reviewable |
Thanks for your reviews! Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful. iris/loader.js, line 51 at r2 (raw file): Previously, davidsoergel (David Soergel) wrote…
Done. iris/serve.sh, line 31 at r2 (raw file): Previously, davidsoergel (David Soergel) wrote…
Restored. iris/serve.sh, line 31 at r2 (raw file): Previously, bileschi (Stanley Bileschi) wrote…
Restored Comments from Reviewable |
file system, a) to avoid confusion, b) this functionality is not
highly useful anymore.
started resizing. This PR makes then fixed, as they should be.
Towards: tensorflow/tfjs#13
This change is