Skip to content

[wasm] Enable execution in node #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 9, 2019
Merged

[wasm] Enable execution in node #2520

merged 7 commits into from
Dec 9, 2019

Conversation

dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Dec 9, 2019

Make the WASM backend work in node. Also:

  • Enable node tests in CI
  • Reduce log outputs when running tests in core.
  • Fix Add WASM backend #1497 (comment) (tfjs_backend_wasm.default is not a fuction)
  • Remove pre-install script which causes yarn of a third-party project that uses the wasm backend to spin indefinitely.

FEATURE


This change is Reviewable

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 20 of 22 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @nsthorat)

Copy link
Contributor Author

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained


tfjs-backend-wasm/tsconfig.json, line 10 at r1 (raw file):

  ],
  "compilerOptions": {
    "esModuleInterop": true,

this fixes #1497 (comment)


tfjs-core/src/engine_test.ts, line 708 at r1 (raw file):

// WebGL state is initialized, which causes the two backends to step on
// each other and get in a bad state.
describe('Memory allocation outside a test scope', () => {

moved to backend_cpu since it explicitly uses 'cpu' backend, which causes to log the message "Hi there. Looks like you are running...." which causes confusion when running unit tests using the wasm backend.

@dsmilkov dsmilkov merged commit 92fb9e5 into master Dec 9, 2019
@dsmilkov dsmilkov deleted the wasm-node branch December 9, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WASM backend
3 participants