Skip to content

Conversation

DEKHTIARJonathan
Copy link
Member

@DEKHTIARJonathan DEKHTIARJonathan commented May 22, 2018

This PR aims to insure that TL is compatible with not only the latest version of TF.
I have taken a history of 1 year into account.

To insure that no-one is using TL with a TF version lower than 1.6.0 I have added a small test on import, it raises the following error if the TF version is inferior to 1.6.0.

>>> import tensorflow as tf
>>> import tensorlayer as tl

Traceback (most recent call last):
ImportError: __init__.py : Could not import TensorLayer.
Error: TensorLayer does not support Tensorflow version older than 1.6.0.
Please update Tensorflow with:
 - `pip install --upgrade tensorflow`
 - `pip install --upgrade tensorflow-gpu`

Highlighted Failures:

Travis is now building the following: Travis Build

image

@DEKHTIARJonathan DEKHTIARJonathan changed the title TF Build Matrix added for Travis [WIP] TF Build Matrix added for Travis May 22, 2018
@DEKHTIARJonathan
Copy link
Member Author

DEKHTIARJonathan commented May 22, 2018

@zsdonghao @lgarithm @luomai

As you can see, we have broken support for any TF version older than 1.6.0. So TL users must use a TF version which is less than 2 months old.

Is it something that we want to fix ? If not, I'll remove the build support for any version older than 1.6.0.
If we want to fix this issue, where do you want to stop backward support ?

When TF versions older than 1.6.0 are removed, we obtain the following:

image

@DEKHTIARJonathan DEKHTIARJonathan changed the title [WIP] TF Build Matrix added for Travis TF Build Matrix added for Travis May 22, 2018
@DEKHTIARJonathan DEKHTIARJonathan merged commit 96a8adb into master May 22, 2018
@DEKHTIARJonathan DEKHTIARJonathan deleted the Travis_Build_Matrix branch May 22, 2018 11:17
luomai pushed a commit that referenced this pull request Nov 21, 2018
* TF Build Matrix added for Travis

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Travis only deploying with TF 1.8.0

* Not Compatible TF Versions Removed

* Changelog Configuration Updated

* Changelog Update

* TF Versions older than 1.6.0 raises an exception

* Readme Badge Updated with supported TF & Python Versions

* Travis Building only the branch `master` and all PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants