-
Notifications
You must be signed in to change notification settings - Fork 1.6k
TF Build Matrix added for Travis #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As you can see, we have broken support for any TF version older than 1.6.0. So TL users must use a TF version which is less than 2 months old. Is it something that we want to fix ? If not, I'll remove the build support for any version older than 1.6.0. When TF versions older than 1.6.0 are removed, we obtain the following: |
zsdonghao
approved these changes
May 22, 2018
Merged
luomai
pushed a commit
that referenced
this pull request
Nov 21, 2018
* TF Build Matrix added for Travis * Update .travis.yml * Update .travis.yml * Update .travis.yml * Travis only deploying with TF 1.8.0 * Not Compatible TF Versions Removed * Changelog Configuration Updated * Changelog Update * TF Versions older than 1.6.0 raises an exception * Readme Badge Updated with supported TF & Python Versions * Travis Building only the branch `master` and all PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to insure that TL is compatible with not only the latest version of TF.
I have taken a history of 1 year into account.
To insure that no-one is using TL with a TF version lower than 1.6.0 I have added a small test on import, it raises the following error if the TF version is inferior to 1.6.0.
Highlighted Failures:
Travis is now building the following: Travis Build