tl.layers API Refactoring and various modifications #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
June 1, 2018 15:02
# Conflicts: # CHANGELOG.md
added 2 commits
June 1, 2018 20:37
added 2 commits
June 1, 2018 20:58
DEKHTIARJonathan
requested review from
zsdonghao and
luomai
and removed request for
zsdonghao and
luomai
|
why we put |
DEKHTIARJonathan
changed the title
DEKHTIARJonathan
changed the title
|
If this is fine with you, this PR can be merged. No hurry anyway ;) |
|
@zsdonghao The idea was to remove redundant code that was everywhere. Maybe it is not the best idea, I can change it, if its a problem. The idea is to design one systematic manner to handle dictionary arguments |
zsdonghao
approved these changes
Jun 2, 2018
added 2 commits
June 2, 2018 16:12
luomai
pushed a commit
that referenced
this pull request
Nov 21, 2018
* Decorators API Refactored * extra_requires `all`, `all_cpu` and `all_gpu` added * Error fix * YAPF Formating Correction * Test for private method decorator added * Test Logging Verbosity Fixed to Debug when runned individually * YAPF corrections applied * Changelog Added * Changelog updated * PR number changed * First Refactoring Pass done * cleaning second pass * Refactoring 3rd pass * Refactoring 4th Pass * Code Error fix * YAPF Formating Fix * Arguments now using self * YAPF error correction * Bug Fix in Decorator * act name bug fix * Error Correction * YAPF formating fix * Useless tf.identity removed * Error Fix * Changelog Updated * Error fix in tl.activation * Documentation error fix * Lazy Import added * Import Refactoring with LazyImport when necessary * Changelog Updated * Gitter Removed * Fixed proposed by @zsdonghao * Documentation updated * Missing requirements added * Update to TensorLayer 1.8.6rc1 * Requirements error fix * Docker Files updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Added
tl.lazy_imports.LazyImportto import heavy libraries only when necessary (by @DEKHTIARJonathan in tl.layers API Refactoring and various modifications #667)Changed
tf.identityas activation is ignored, thus reducing the size of the graph by removing useless operation (by @DEKHTIARJonathan in tl.layers API Refactoring and various modifications #667)LayerBase Class (by @DEKHTIARJonathan in tl.layers API Refactoring and various modifications #667)Deprecated
tl.layers.TimeDistributedLayerargurmentargsis deprecated in favor oflayer_args(by @DEKHTIARJonathan in tl.layers API Refactoring and various modifications #667)Removed
assert()calls remove and replaced byraise AssertionError()(by @DEKHTIARJonathan in tl.layers API Refactoring and various modifications #667)tl.identityis rFixed
private_method(by @DEKHTIARJonathan in tl.layers API Refactoring and various modifications #667)