-
Notifications
You must be signed in to change notification settings - Fork 1
terminusdb.yaml fails to validate due to requestBody in DELETE #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Not allowing |
I like valid things, so I would like to have CI to validate
|
We should ignore the specific error regarding request body in DELETE if it's not too much trouble. Otherwise get rid of CI validation. |
* Validate OpenAPI specifications against the Swagger Editor * Ignoring error: DELETE operations cannot have a requestBody * Fixes #3
* Validate OpenAPI specifications against the Swagger Editor * Ignoring error: DELETE operations cannot have a requestBody * Fixes #3
Thanks to https://github.com/char0n/swagger-editor-validate/pull/126, we can ignore the error! 🎉 |
The OpenAPI 3.0 specification disallows
requestBody
inDELETE
:RFC 7231:
This currently causes
terminusdb.yaml
to fail validation with the Swagger Editor.Endpoints like
/api/db
and/api/document
support JSON in theDELETE
request. I believe the use of the request body is not integral to the semantics of the operation. That is, we could replace the JSON request body with query parameters that serve the same purpose.The latest release of the OpenAPI specification, v3.1.0, allows
requestBody
inDELETE
:However, the Swagger Editor does not yet support OpenAPI 3.1. Also, there aren't many OpenAPI tools that support 3.1.
The text was updated successfully, but these errors were encountered: