Feature to disable default 0.0.0.0/0 route for public subnets

[HasseJohansen]

Is your request related to a new offering from AWS?

This feature is not bound to a specific AWS feature(other than used by the VPC module already)

Is your request related to a problem? Please describe.

When using network firewall we need to be able to have a default route through the network firewall for our public subnets

As the VPC today always creates the 0.0.0.0/0 route (and also creates the route table for the public subnets). We have no way to use the this VPC module with a network firewall

Describe the solution you'd like.

I think the simplest solution with least change is to be able to disable the creation of the default route for public subnets

Describe alternatives you've considered.

The alternative I considered first was having a toggle to disable creating the route table(s) for public subnets and then provide "my own" route table(s)

Additional context

Would this be an ok approach?

[HasseJohansen]

I have made a PR here #1188

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

[HasseJohansen]

Hi. I still think this is useful feature. I would like to have it merged. I can see that there is a PR which disables the routable creation also(#1190). That can also help in my usecase, but I was going for the smallest change for my requirement

Hope you will consider it

[springroll12]

This small PR would be a huge improvement to this module.

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

[HasseJohansen]

Please react to the PR instead of letting the bot autoclosing it