Skip to content

fix(mongodb): waiting for container to start (it was not waiting at all before?) #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2024
Merged

fix(mongodb): waiting for container to start (it was not waiting at all before?) #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions modules/mongodb/testcontainers/mongodb/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

from testcontainers.core.generic import DbContainer
from testcontainers.core.utils import raise_for_deprecated_parameter
from testcontainers.core.waiting_utils import wait_container_is_ready
from testcontainers.core.waiting_utils import wait_for_logs


class MongoDbContainer(DbContainer):
Expand Down Expand Up @@ -81,9 +81,8 @@ def get_connection_url(self) -> str:
port=self.port,
)

@wait_container_is_ready()
def _connect(self) -> MongoClient:
return MongoClient(self.get_connection_url())
def _connect(self) -> None:
wait_for_logs(self, "Waiting for connections")

def get_connection_client(self) -> MongoClient:
return self._connect()
return MongoClient(self.get_connection_url())