Skip to content

Conversation

alexanderankin
Copy link
Member

@alexanderankin alexanderankin commented Jul 24, 2024

fix #652

@alexanderankin alexanderankin added the community-feat feature but its a community module so we wont bump tc core for it label Jul 24, 2024
@alexanderankin alexanderankin changed the title fix: add Arg/Options to api of selenium container fix(selenium): add Arg/Options to api of selenium container Jul 25, 2024
@alexanderankin
Copy link
Member Author

help is appreciated to determine why the docs arent building here

@alexanderankin
Copy link
Member Author

could this setting help? numpy/numpy#23058 (comment)

@kiview kiview self-requested a review August 1, 2024 14:49
@kiview
Copy link
Member

kiview commented Aug 1, 2024

@alexanderankin I think this is more related: python/typeshed#7379 (are we using Typeshed even?)

@alexanderankin
Copy link
Member Author

thanks @kiview for the hint about how to fix it via intersphinx config

@alexanderankin alexanderankin merged commit e02c1b3 into main Aug 1, 2024
@alexanderankin alexanderankin deleted the feat/selenium-options branch August 1, 2024 15:06
alexanderankin pushed a commit that referenced this pull request Aug 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.8.0](testcontainers-v4.7.2...testcontainers-v4.8.0)
(2024-08-14)


### Features

* Adding support for Cassandra and Scylla
([#167](#167))
([2d8bc11](2d8bc11))
* **compose:** ability to retain volumes when using context manager
([#659](#659))
([e1e3d13](e1e3d13))
* **compose:** add ability to get docker compose config
([#669](#669))
([8c28a86](8c28a86))
* **core:** add ability to do OR & AND for waitforlogs
([#661](#661))
([b1453e8](b1453e8))
* **new:** Added AWS Lambda module
([#655](#655))
([9161cb6](9161cb6))
* refactor network setup
([#678](#678))
([d5de0aa](d5de0aa))


### Bug Fixes

* Add Db2 support
([#673](#673))
([1e43923](1e43923))
* bring back cassandra driver bc otherwise how does it get installed for
cassandra module test run?
([#680](#680))
([71c3a1a](71c3a1a))
* **rabbitmq:** add `vhost` as parameter to RabbitMqContainer
([#656](#656))
([fa2081a](fa2081a))
* **selenium:** add Arg/Options to api of selenium container
([#654](#654))
([e02c1b3](e02c1b3)),
closes
[#652](#652)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-feat feature but its a community module so we wont bump tc core for it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: where to add the Chrome options for BrowserWebDriverContainer
2 participants