Skip to content

fix: Enable mypy in the CI #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 3, 2025
Merged

fix: Enable mypy in the CI #842

merged 7 commits into from
Jul 3, 2025

Conversation

Tranquility2
Copy link
Contributor

@Tranquility2 Tranquility2 commented Jul 2, 2025 •
edited
Loading

  1. leftovers from a previous mypy refactor
core/testcontainers/core/config.py:42: error: Redundant cast to "str"  [redundant-cast]
            socket_path = cast("str", socket_path)

Post fix:

#poetry run mypy --config-file pyproject.toml core
Success: no issues found in 36 source files
  1. add mypy check to the CI under lint, also create a simple report if something is wrong.

@Tranquility2 Tranquility2 changed the title fix: address mypy issue in config fix: Enable mypy in the CI Jul 2, 2025
@Tranquility2 Tranquility2 force-pushed the fix_mypy_config branch 2 times, most recently from 201cd8a to 309efdf Compare July 3, 2025 09:36
@Tranquility2
add mypy + report
e31efa2 
fix report

more report fixes

fix pipeline

fix2
@Tranquility2 Tranquility2 force-pushed the fix_mypy_config branch 2 times, most recently from e201113 to af6b0b9 Compare July 3, 2025 11:14
@Tranquility2
Copy link
Contributor Author

Happy flow:
image

On error:
image

alexanderankin
alexanderankin approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@alexanderankin alexanderankin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with the caveat that i have not run the mypy_report.py on my laptop once yet

@Tranquility2 Tranquility2 merged commit ef65bd1 into main Jul 3, 2025
8 checks passed
@Tranquility2 Tranquility2 deleted the fix_mypy_config branch July 3, 2025 12:26
@github-actions github-actions bot mentioned this pull request Jul 3, 2025
Merged
alexanderankin pushed a commit that referenced this pull request Jul 21, 2025
@github-actions
chore(main): release testcontainers 4.12.0 (#834)
d40473f 
🤖 I have created a release *beep* *boop*
---


##
[4.12.0](testcontainers-v4.11.0...testcontainers-v4.12.0)
(2025-07-21)


### Features

* **main:** New Testcontainers Python Docs Site
([#822](#822))
([a6bdf0e](a6bdf0e))
* make config monkeypatchable, fix config related startup issues
([#833](#833))
([ff6a32d](ff6a32d))
* **modules:** add OpenFGA module
([#762](#762))
([0b7b482](0b7b482))
* set multiple variables via keyword args
([#804](#804))
([1532df5](1532df5))


### Bug Fixes

* **core:** mypy
([#810](#810))
([b816762](b816762))
* Enable mypy in the CI
([#842](#842))
([ef65bd1](ef65bd1))
* just use the getLogger API and do not override logger settings
([#836](#836))
([f467c84](f467c84))


### Documentation

* missing compose html from old docs
([#776](#776))
([d749fc6](d749fc6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderankin alexanderankin alexanderankin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tranquility2 @alexanderankin