-
Notifications
You must be signed in to change notification settings - Fork 338
chore: add support for building with python 3.13 #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support for building with python 3.13 #871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im mostly ok with this except of the increase in testing matrix size. im not sure which one to remove, 3.9 is important for backwards compatibility and i wanted to say 3.11 is still the default but i think ubuntu 24 ships with 3.12 now, so idk
.github/workflows/ci-core.yml
Outdated
fail-fast: false | ||
matrix: | ||
python-version: ["3.9", "3.10", "3.11", "3.12"] | ||
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in order to not increase the bills for the github org, i think we should drop one.
@alexanderankin if adding a new item to the matrix really increase the cost on the testcontainers org, we could go with 3.10 then? I was checking the GitHub workflows, and I am wondering if you could save up some resources by only enabling coverage on a single python version, I mean, your code should not have any specific version branching requiring to combine each coverage. Using the coverage has a cost, you could also remove the
Another idea would be to only run the docs/tests on one version of python? testcontainers-python/.github/workflows/ci-core.yml Lines 41 to 42 in 9b99442
|
lets remove 3.10 then |
Signed-off-by: axel7083 <[email protected]>
@alexanderankin I applied your suggestion and removed the python 3.10 👍 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
=======================================
Coverage ? 78.71%
=======================================
Files ? 14
Lines ? 1156
Branches ? 180
=======================================
Hits ? 910
Misses ? 206
Partials ? 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
testcontainers-python
is not compatible with python 3.13 because of several packages.Related issues
Fixes #870
Packages update
Path
for Python 3.13 python-trio/trio#2955