Skip to content

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Sep 9, 2025

@alexanderankin alexanderankin changed the title chore: add support for python 3.13 chore: add support for building with python 3.13 Sep 9, 2025
Copy link
Member

@alexanderankin alexanderankin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im mostly ok with this except of the increase in testing matrix size. im not sure which one to remove, 3.9 is important for backwards compatibility and i wanted to say 3.11 is still the default but i think ubuntu 24 ships with 3.12 now, so idk

fail-fast: false
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in order to not increase the bills for the github org, i think we should drop one.

@axel7083
Copy link
Contributor Author

axel7083 commented Sep 9, 2025

im mostly ok with this except of the increase in testing matrix size. im not sure which one to remove, 3.9 is important for backwards compatibility and i wanted to say 3.11 is still the default but i think ubuntu 24 ships with 3.12 now, so idk

@alexanderankin if adding a new item to the matrix really increase the cost on the testcontainers org, we could go with 3.10 then?


I was checking the GitHub workflows, and I am wondering if you could save up some resources by only enabling coverage on a single python version, I mean, your code should not have any specific version branching requiring to combine each coverage.

Using the coverage has a cost, you could also remove the coverage-compile and directly use the codecov/codecov-action@v5 action instead of having a dedicated job.

Another idea would be to only run the docs/tests on one version of python?

- name: Run doctests
run: make core/doctests

@alexanderankin
Copy link
Member

lets remove 3.10 then

@axel7083
Copy link
Contributor Author

axel7083 commented Sep 9, 2025

@alexanderankin I applied your suggestion and removed the python 3.10 👍

Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@504957b). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #871   +/-   ##
=======================================
  Coverage        ?   78.71%           
=======================================
  Files           ?       14           
  Lines           ?     1156           
  Branches        ?      180           
=======================================
  Hits            ?      910           
  Misses          ?      206           
  Partials        ?       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexanderankin alexanderankin merged commit aa47435 into testcontainers:main Sep 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: add support for building with python 3.13
2 participants