-
Notifications
You must be signed in to change notification settings - Fork 155
(TS) Type SelectorMatcherOptions is missing timeout #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for this. Could you make a pull request for this? |
I could try. It would be my very first PR though. I'll try to follow your course on egghead and contributing guide and see how far can I make it 🙂. |
Please note that I'm not currently using the TypeScript types in any project so I'll need another reviewer to review/merge these changes. Thanks! |
@ShimiTheFirst your solution looks fine to me. Just did just that locally and it works. For a simple change like this I would simply use the GitHub web frontend to create a PR. In fact I did just that #48 |
Simply created a PR based on the changes ShimiTheFirst suggested here #43
@all-contributors please add @ShimiTheFirst for bugs |
I've put up a pull request to add @ShimiTheFirst! 🎉 |
Thanks to both of you for this! |
cypress-testing-library
version: 3.0.1node
version: 10.13.0yarn
version: 1.13.0Relevant code or config
What you did:
Tried to change the value of the timeout option on
queryByText
.What happened:

The test correctly waited for the set amount of time (100ms) but TS validation reports an error:
Problem description:
Queries using the
SelectorMatcherOptions
type are missing the type definition for the timeout option.Suggested solution:
If this is not intentional, take the same approach as for
MatcherOptions
in #28 – updatetypings/index.d.ts
.How it is now:
How it could be:
The text was updated successfully, but these errors were encountered: