feat(getByRole): Allow filter by disabled #1231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dd179c7:
|
kemuridama
force-pushed
the
allow_filter_by_disabled
branch
from
c63de5c to
dd179c7
Compare
Codecov Report
@@ Coverage Diff @@
## main #1231 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1042 1046 +4
Branches 351 349 -2
=========================================
+ Hits 1042 1046 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hi @kemuridama! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR allows
getByRole()filter bydisabledattribute.We often write tests depending on
disabledoraria-disabledattribute of elements, butgetByRole()method cannot filter by it.There are different meaning between
disabledandaria-disabledattribute slightly.disabledmakes a element be unclickable and unfocusable, but a element setting byaria-disabled: trueremains clickable and focusable.https://codepen.io/kemuridama/pen/rNqJKqm
From that differences, I have 2 solutions to filter by
disabledattribute:disabledandaria-disabledattributedisabledattribute onlyThis PR resolves using the former solution, but there are controvertible.
Why:
To write tests depending on
disabledoraria-disabledattribute of elements easily.How:
Same patterns as for
expanded,selectedetcChecklist: