Skip to content

fix: support Node >=10 #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Conversation

NMinhNguyen
Copy link
Contributor

@NMinhNguyen NMinhNguyen commented Mar 6, 2020

This is a follow-up to #459.

What: support older Node 10 versions

Why: to make the upgrade easier since there doesn't appear to be a hard requirement to use Node 10.18 (see #459 (comment)).

How: changed engines.node from >=10.18 to >=10.

Checklist:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b8fda9e:

Sandbox Source
new-waterfall-75jju Configuration

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #465 into beta will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           beta   #465   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        22     22           
  Lines       420    420           
  Branches    100    100           
===================================
  Hits        420    420

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46cbcda...b8fda9e. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit de9ac27 into testing-library:beta Mar 6, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @NMinhNguyen for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @NMinhNguyen! 🎉

@NMinhNguyen NMinhNguyen deleted the patch-1 branch March 7, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants