Skip to content

Fix incorrect imports in types #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 7, 2020
Merged

Fix incorrect imports in types #556

merged 5 commits into from
May 7, 2020

Conversation

nstepien
Copy link
Contributor

@nstepien nstepien commented May 7, 2020

What: Fixing invalid imports

> tsc -p tsconfig.all.json

node_modules/@testing-library/dom/types/queries.d.ts:3:32 - error TS2307: Cannot find module 'wait-for'.

3 import { waitForOptions } from 'wait-for';
                                 ~~~~~~~~~~

node_modules/@testing-library/dom/types/wait-for-dom-change.d.ts:1:32 - error TS2307: Cannot find module 'index'.

1 import { waitForOptions } from "index";
                                 ~~~~~~~

node_modules/@testing-library/dom/types/wait-for-element-to-be-removed.d.ts:1:32 - error 
TS2307: Cannot find module 'wait-for'.

1 import { waitForOptions } from "wait-for";
                                 ~~~~~~~~~~

node_modules/@testing-library/dom/types/wait-for-element.d.ts:1:32 - error TS2307: Cannot find module 'wait-for'.

1 import { waitForOptions } from "wait-for";
                                 ~~~~~~~~~~


Found 4 errors.

Why: It's breaking my builds

How: N/A

Checklist:

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9e0cb20:

Sandbox Source
serene-wescoff-6qgzw Configuration

@@ -1,4 +1,3 @@
import { Matcher } from './matches';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's unused.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit af15dd9 into testing-library:master May 7, 2020
@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kentcdodds
Copy link
Member

@all-contributors please add @nstepien for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @nstepien! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants