Skip to content

chore: revert pretty-format dependency upgrade #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2020
Merged

chore: revert pretty-format dependency upgrade #571

merged 2 commits into from
May 13, 2020

Conversation

exogen
Copy link
Contributor

@exogen exogen commented May 13, 2020

What: Downgrade pretty-format to v25.

Why: The newer v26 bumps the minimum required version of Node. See #563.

How: Update version in package.json

Checklist:

  • Documentation added to the docs site – N/A
  • I've prepared a PR for types targeting DefinitelyTyped – N/A
  • Tests – no new tests, but verified that they pass
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3826348:

Sandbox Source
stupefied-flower-bes9y Configuration

@exogen
Copy link
Contributor Author

exogen commented May 13, 2020

@kentcdodds If you still want to bump it vs. what was there before, I'm happy to update the range to ^25.5.0 which presumably will still keep the compatible Node version.

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #571 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #571   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          459       459           
  Branches       113       113           
=========================================
  Hits           459       459           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 217b2a8...3826348. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks :) I double checked the changelog and we're not losing much by not upgrading so I don't think we need to worry about upgrading any time soon.

@kentcdodds kentcdodds merged commit eb4e0d7 into testing-library:master May 13, 2020
@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants