no-manual-cleanup does not like require(modulaName)

[kentcdodds]

I've got code like this:

require(moduleName)

and no-manual-cleanup does this:

TypeError: Cannot read property 'match' of undefined
Occurred while linting /Users/kentcdodds/code/kcd-scripts/src/utils.js:39
    at VariableDeclarator (/Users/kentcdodds/code/kcd-scripts/node_modules/eslint-plugin-testing-library/rules/no-manual-cleanup.js:71:73)
    at /Users/kentcdodds/code/kcd-scripts/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/Users/kentcdodds/code/kcd-scripts/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/Users/kentcdodds/code/kcd-scripts/node_modules/eslint/lib/linter/node-event-generator.js:254:26)
    at NodeEventGenerator.applySelectors (/Users/kentcdodds/code/kcd-scripts/node_modules/eslint/lib/linter/node-event-generator.js:283:22)
    at NodeEventGenerator.enterNode (/Users/kentcdodds/code/kcd-scripts/node_modules/eslint/lib/linter/node-event-generator.js:297:14)
    at CodePathAnalyzer.enterNode (/Users/kentcdodds/code/kcd-scripts/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:634:23)
    at /Users/kentcdodds/code/kcd-scripts/node_modules/eslint/lib/linter/linter.js:936:32
    at Array.forEach (<anonymous>)

This is because of this code:

eslint-plugin-testing-library/lib/rules/no-manual-cleanup.ts

Lines 65 to 66 in 3439a29

	const value = node.source.value as string;
	const testingLibraryWithCleanup = value.match(CLEANUP_LIBRARY_REGEX);

It should check whether value exists before calling match :)

[Belco90]

Hey Kent! Thanks for open an issue so detailed. This one should be easy to fix, I'll try to take a look at it this weekend if no one else can address it before.

[Belco90]

🎉 This issue has been resolved in version 3.1.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[Belco90]

@all-contributors please add @kentcdodds for bugs

[allcontributors]

@Belco90

I've put up a pull request to add @kentcdodds! 🎉

[kentcdodds]

Sweet! Thanks 👍