Skip to content

fix(no-manual-cleanup): check require imports properly #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dmitry-lobanov
Copy link
Contributor

This closes #125

Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Dmitry! Thanks for you PR, it looks perfect 👌

@Belco90 Belco90 changed the title fix: (no-manual-cleanup) match of undefined fix(no-manual-cleanup): check require imports properly May 8, 2020
@Belco90 Belco90 merged commit 28e23a9 into testing-library:master May 8, 2020
@Belco90
Copy link
Member

Belco90 commented May 8, 2020

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Belco90
Copy link
Member

Belco90 commented May 8, 2020

@all-contributors please add @dmitry-lobanov for code and tests

@allcontributors
Copy link
Contributor

@Belco90

I've put up a pull request to add @dmitry-lobanov! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-manual-cleanup does not like require(modulaName)
2 participants