-
Notifications
You must be signed in to change notification settings - Fork 149
prefer-user-event should consider the use case where fireEvent is used as a function #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This one must wait until v4 is released. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
now that v4 is released, we can tackle this one. I think I can tackle it the next week, so if no one takes it during that time, I might do so |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I'm taking this one so stale bot doesn't close it 😆 I'll tackle it during the week |
* feat: add support for fireEvent as function in prefer-user-event * refactor: use getDeepestIdentifierNode to detect in isCreateEventUtil Co-authored-by: Mario Beltrán Alarcón <[email protected]> Closes #261
🎉 This issue has been resolved in version 4.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
In addition to the method events like
fireEvent.click
, it is also possible to create custom events objects and usefireEvent
as a function, as the documentation for fireEvent showsThe rule should recommend to use
userEvent.click()
the rule should consider this form too
Note: This rule has been migrated in the
v4
branch, so anyone taking this issue should do so starting from branchv4
(And targeting it as well)The text was updated successfully, but these errors were encountered: