Skip to content

no-unnecessary-act: option for strict reporting #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Belco90 opened this issue May 13, 2021 · 4 comments · Fixed by #404
Closed

no-unnecessary-act: option for strict reporting #382

Belco90 opened this issue May 13, 2021 · 4 comments · Fixed by #404
Assignees
@Belco90
Labels
enhancement New feature or request released

Comments

@Belco90
Copy link
Member

Belco90 commented May 13, 2021

Since the current implementation of no-unnecessary-act doesn't report act usages with react-testing-library calls inside if mixed with non-react-testing-library, it would be interesting to add a new isStrict option (false by default) which makes the rule to always report react-testing-library calls inside act no matter if mixed with non-react-testing-library.
@Belco90
Copy link
Member Author

Belco90 commented May 13, 2021

@zaicevas this is the issue I mentioned to tackle the strict reporting in no-unnecessary-act.

@Belco90 Belco90 added the enhancement New feature or request label May 13, 2021
@Belco90 Belco90 self-assigned this May 22, 2021
@zaicevas
Copy link
Contributor

zaicevas commented Jul 6, 2021

@Belco90 do you mind if I'll try to implement it?

@Belco90
Copy link
Member Author

Belco90 commented Jul 6, 2021

@Belco90 do you mind if I'll try to implement it?

By all means! I won't have much spare time during summer, so I'd really appreciate if you can take care of this one.

@zaicevas zaicevas mentioned this issue Jul 6, 2021
Merged
Belco90 pushed a commit that referenced this issue Jul 6, 2021
@zaicevas
feat(no-unnecessary-act): add isStrict option (#404)
b68d66b 
* feat: isStrict option for no-unnecessary-act

* refactor: rename and simplify isReported -> shouldBeReported

* refactor: specify in docs that isStrict is disabled by default

Closes #382
@github-actions
Copy link

github-actions bot commented Jul 6, 2021

🎉 This issue has been resolved in version 4.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Belco90 Belco90

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: isStrict option for no-unnecessary-act zaicevas/eslint-plugin-testing-library
2 participants
@Belco90 @zaicevas