Skip to content

feat: add support for fireEvent as function in prefer-user-event #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2021

Conversation

gndelia
Copy link
Collaborator

@gndelia gndelia commented Jun 23, 2021

closes #261
It's been a while since the last time I worked in rules here and with eslint/AST. I was a bit out of shape 🤣 so it took me more than I originally expected. Any feedback is appreciated!

@gndelia gndelia added the enhancement New feature or request label Jun 23, 2021
@gndelia gndelia requested review from Belco90 and timdeschryver June 23, 2021 01:41
@gndelia gndelia self-assigned this Jun 23, 2021
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see you back @gndelia! Nice addition, I requested a small refactor to simplify one of the new functions but everything else looks god to me.

@gndelia gndelia requested a review from Belco90 July 3, 2021 19:18
@Belco90 Belco90 merged commit 0c11511 into main Jul 4, 2021
@Belco90 Belco90 deleted the feat/prefer-user-event/fire-event-as-function branch July 4, 2021 12:25
@github-actions
Copy link

github-actions bot commented Jul 4, 2021

🎉 This PR is included in version 4.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefer-user-event should consider the use case where fireEvent is used as a function
2 participants