Skip to content

Bug: isStrict option in no-unnecessary-act only reports strict violations #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zaicevas opened this issue Jul 19, 2021 · 2 comments · Fixed by #423
Closed

Bug: isStrict option in no-unnecessary-act only reports strict violations #416

zaicevas opened this issue Jul 19, 2021 · 2 comments · Fixed by #423
Labels
bug Something isn't working released

Comments

@zaicevas
Copy link
Contributor

With isStrict: true the no-unnecessary-act rule only reports mixed RTL+non RTL calls, but does not report act with only RTL calls, which is the behaviour without isStrict enabled.

      await act(async () => {
        userEvent.click(contactSupport) // not reported when isStrict is true
      })

I'll take a look at this one when I have the time.
@Belco90 Belco90 added the bug Something isn't working label Jul 19, 2021
@Belco90
Copy link
Member

Belco90 commented Jul 19, 2021

This should have been caught by some test 😞

@zaicevas zaicevas mentioned this issue Jul 20, 2021
Merged
Belco90 pushed a commit that referenced this issue Jul 21, 2021
@zaicevas
fix(no-unnecessary-act): report everything that's reported in non-str…
840763d 
…ict (#423)

* fix(no-unnecessary-act): report everything that's reported in non-strict

* refactor: remove duplication in tests

Co-authored-by: Michaël De Boey <[email protected]>

Closes #416
@github-actions
Copy link

🎉 This issue has been resolved in version 4.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
2 participants
@Belco90 @zaicevas