Skip to content

fix(prefer-find-by): fix report with querySelector #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2022
Merged

fix(prefer-find-by): fix report with querySelector #538

merged 2 commits into from
Jan 21, 2022

Conversation

bpinto
Copy link
Contributor

@bpinto bpinto commented Jan 20, 2022

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list.
  • If some rule meta info is changed, I've regenerated the plugin shared configs.

Changes

  • No longer report invalid usages with a missing query method.
  • Add a test covering the code changes.

Context

Fixes #501

@bpinto
Copy link
Contributor Author

bpinto commented Jan 20, 2022 •
edited
Loading

It's my first contribution to the project so if my fix is bad/wrong let me know how I can improve this.

Belco90
Belco90 requested changes Jan 21, 2022
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bpinto! Thanks for your first contribution. The fix itself seems fine but handles the original issue partially. I've pointed out somewhere else where you need to apply the fix.

@bpinto bpinto force-pushed the pr/fix-wait-for-and-query-selector branch from c3b84f7 to 93e33ed Compare January 21, 2022 13:58
Belco90
Belco90 approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thank you very much!

@Belco90 Belco90 added the bug Something isn't working label Jan 21, 2022
@Belco90 Belco90 merged commit 369e24f into testing-library:main Jan 21, 2022
@Belco90
Copy link
Member

Belco90 commented Jan 21, 2022

@all-contributors please add @bpinto for code and test.

@allcontributors allcontributors bot mentioned this pull request Jan 21, 2022
Merged
@allcontributors
Copy link
Contributor

@Belco90

I've put up a pull request to add @bpinto! 🎉

@github-actions
Copy link

🎉 This PR is included in version 5.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bpinto bpinto deleted the pr/fix-wait-for-and-query-selector branch January 21, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prefer-find-by reports querySelector
2 participants
@bpinto @Belco90