Skip to content

migrate to typescript-eslint #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 4, 2020
Merged

migrate to typescript-eslint #121

merged 7 commits into from
May 4, 2020

Conversation

timdeschryver
Copy link
Member

  • migrate to typescript-eslint
  • updates the tooling
  • modifies the build step
  • publish the dist folder
  • run build and test during CI
  • adds util funtions

@Belco90
Copy link
Member

Belco90 commented May 2, 2020

I told you this several times before on DM but mate I can't thank you enough for this! The PR looks fantastic, I'll give it a try to the final bundle on my project during the weekend.

@Belco90
Copy link
Member

Belco90 commented May 3, 2020

I've published a beta version in npm, it's published here

There are few things to fix:

  • now the folder to publish is distrather than . so we need to config this in semantic release (I need to figure this)
  • after installing it in another project, it doesn't seem to work properly:
    image

I'm using node v10.20.1 and npm v6.14.4 but I can't find what's wrong here.

@timdeschryver
Copy link
Member Author

  1. Was it released via semantic release? It should've been configured with

    "release": {
    "pkgRoot": "dist"
    },

  2. I'll take a look at it. I had the same problem while I did some tests with it, I must have forgotten to commit the change.

@timdeschryver
Copy link
Member Author

Should be resolved with the latest commit, could you try again please?

@Belco90
Copy link
Member

Belco90 commented May 3, 2020

Published beta 3 and tested again. Looking fine now! We are ready to release it then, I’ll prepare everything for doing it tomorrow.

@Belco90 Belco90 merged commit 3439a29 into master May 4, 2020
@Belco90 Belco90 deleted the typescript-eslint branch May 4, 2020 10:41
@Belco90
Copy link
Member

Belco90 commented May 4, 2020

@all-contributors please add @timdeschryver for infra and platform

@allcontributors
Copy link
Contributor

@Belco90

I've put up a pull request to add @timdeschryver! 🎉

@Belco90
Copy link
Member

Belco90 commented May 4, 2020

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants